Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] FrozenLake RGB rendering returns None #2600

Closed
trigaten opened this issue Feb 7, 2022 · 4 comments · Fixed by #2601
Closed

[Bug Report] FrozenLake RGB rendering returns None #2600

trigaten opened this issue Feb 7, 2022 · 4 comments · Fixed by #2601

Comments

@trigaten
Copy link
Contributor

trigaten commented Feb 7, 2022

FrozenLake render() method in mode human always returns None and lacks an rgb_array render mode. For reference, Blackjack has recently been converted to pygame and implements these features correctly.

@younik I believe you converted FrozenLake to pygame?

@younik
Copy link
Contributor

younik commented Feb 7, 2022

@trigaten if you pass mode='ansi' it returns the old render mode; otherwise, it renders in GUI mode.

What should be the expected behaviour with rgb_array?

@trigaten trigaten changed the title [Bug Report] FrozenLake rendering returns None [Bug Report] FrozenLake rgb rendering returns None Feb 7, 2022
@trigaten
Copy link
Contributor Author

trigaten commented Feb 7, 2022

@trigaten if you pass mode='ansi' it returns the old render mode; otherwise, it renders in GUI mode.

Sorry, I amended my comment to specify RGB

What should be the expected behaviour with rgb_array?

As in Blackjack, an RGB array should be returned.

@trigaten trigaten changed the title [Bug Report] FrozenLake rgb rendering returns None [Bug Report] FrozenLake RGB rendering returns None Feb 7, 2022
@younik
Copy link
Contributor

younik commented Feb 7, 2022

As in Blackjack, an rgb array should be returned.

Clear, thank you, I fix it now!

younik added a commit to younik/gym that referenced this issue Feb 7, 2022
@younik younik mentioned this issue Feb 7, 2022
younik added a commit to younik/gym that referenced this issue Feb 7, 2022
jkterry1 added a commit that referenced this issue Feb 8, 2022
* add pygame GUI for frozen_lake.py env

* add new line at EOF

* pre-commit reformat

* improve graphics

* new images and dynamic window size

* darker tile borders and fix ICC profile

* pre-commit hook

* adjust elf and stool size

* Update frozen_lake.py

* reformat

* fix #2600

* #2600

Co-authored-by: J K Terry <jkterry0@gmail.com>
@trigaten
Copy link
Contributor Author

trigaten commented Feb 8, 2022

@younik There is still no RGB render mode which would return an array of pixel values.

jkterry1 added a commit that referenced this issue Feb 11, 2022
* add pygame GUI for frozen_lake.py env

* add new line at EOF

* pre-commit reformat

* improve graphics

* new images and dynamic window size

* darker tile borders and fix ICC profile

* pre-commit hook

* adjust elf and stool size

* Update frozen_lake.py

* reformat

* fix #2600

* #2600

* add rgb_array support

* reformat

Co-authored-by: J K Terry <jkterry0@gmail.com>
jkterry1 added a commit that referenced this issue Jun 7, 2022
* add pygame GUI for frozen_lake.py env

* add new line at EOF

* pre-commit reformat

* improve graphics

* new images and dynamic window size

* darker tile borders and fix ICC profile

* pre-commit hook

* adjust elf and stool size

* Update frozen_lake.py

* reformat

* fix #2600

* #2600

* add rgb_array support

* reformat

* test render api change on FrozenLake

* add render support for reset on frozenlake

* add clock on pygame render

* new render api for blackjack

* new render api for cliffwalking

* new render api for Env class

* update reset method, lunar and Env

* fix wrapper

* fix reset lunar

* new render api for box2d envs

* new render api for mujoco envs

* fix bug

* new render api for classic control envs

* fix tests

* add render_mode None for CartPole

* new render api for test fake envs

* pre-commit hook

* fix FrozenLake

* fix FrozenLake

* more render_mode to super - frozenlake

* remove kwargs from frozen_lake new

* pre-commit hook

* add deprecated render method

* add backwards compatibility

* fix test

* add _render

* move pygame.init() (avoid pygame dependency on init)

* fix pygame dependencies

* remove collect_render() maintain multi-behaviours .render()

* add type hints

* fix renderer

* don't call .render() with None

* improve docstring

* add single_rgb_array to all envs

* remove None from metadata["render_modes"]

* add type hints to test_env_checkers

* fix lint

* add comments to renderer

* add comments to single_depth_array and single_state_pixels

* reformat

* add deprecation warnings and env.render_mode declaration

* fix lint

* reformat

* fix tests

* add docs

* fix car racing determinism

* remove warning test envs, customizable modes on renderer

* remove commments and add todo for env_checker

* fix car racing

* replace render mode check with assert

* update new mujoco

* reformat

* reformat

* change metaclass definition

* fix tests

* implement mark suggestions (test, docs, sets)

* check_render

Co-authored-by: J K Terry <jkterry0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants