Pendulum updates #2423
Merged
Pendulum updates #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the math a bit (no difference in behavior)
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #2156
First change is using the identity that -sin(x + pi) = sin(x)
Second change is the fact that the angular velocity is clipped to the predefined range before being applied to the state of the environment. This way, we are guaranteed that the actual change of the angle between two consecutive timesteps will be constrained in the (-max_speed, max_speed) range. The change in the actual dynamics of the environment is minimal, but technically can be non-zero, so I bumped the version to Pendulum-v1.