Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sys.exit(0) from mujoco renderer when closing environment #2930

Merged

Conversation

rodrigodelazcano
Copy link
Contributor

destroy window mujoco rendering

remove sys.exit

Description

Remove sys.exit(0) from mujoco renderer when closing environment.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

destroy window mujoco rendering

remove sys.exit
@jkterry1
Copy link
Collaborator

Is this what caused the previous bugs in the old version of the mujoco environments where rendering impacted determinism that were never diagnosed?

@rodrigodelazcano
Copy link
Contributor Author

No, that is still an incognito. This avoids terminating the code execution when running and closing multiple environments such as in testing

@pseudo-rnd-thoughts
Copy link
Contributor

LGTM

@jkterry1 jkterry1 merged commit 0dba072 into openai:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants