Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync spec #126

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Sync spec #126

merged 2 commits into from
Nov 27, 2023

Conversation

logankilpatrick
Copy link
Contributor

No description provided.

@rattrayalex rattrayalex mentioned this pull request Nov 16, 2023
Closed
1 task
@davidmigloz davidmigloz mentioned this pull request Nov 16, 2023
Closed
davidmigloz
davidmigloz suggested changes Nov 16, 2023
View reviewed changes
openapi.yaml Outdated Show resolved Hide resolved
openapi.yaml Outdated Show resolved Hide resolved
@logankilpatrick logankilpatrick mentioned this pull request Nov 16, 2023
Closed
@logankilpatrick
Copy link
Contributor Author

Porting more changes, hang tight.

@logankilpatrick
Copy link
Contributor Author

Re-requesting review, no urgent, just wanted to add to the queue for next week so I didn't forget about this.

schnerd
schnerd approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@schnerd schnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving – I'll trust that you've ensured we're not overwriting any public commits from this repo.

@davidmigloz
Copy link
Contributor

are the couple of comments I raised actually resolved? I don't see any commits after those.

@logankilpatrick
Copy link
Contributor Author

Yes, ported now @davidmigloz! Was waiting for an internal PR to land.

@logankilpatrick logankilpatrick merged commit 23a4b18 into master Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmigloz davidmigloz davidmigloz requested changes

@schnerd schnerd schnerd approved these changes

@athyuttamre athyuttamre Awaiting requested review from athyuttamre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@logankilpatrick @davidmigloz @schnerd @athyuttamre