Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring ptxas #1618

Open
SomeoneSerge opened this issue May 4, 2023 · 2 comments
Open

Vendoring ptxas #1618

SomeoneSerge opened this issue May 4, 2023 · 2 comments

Comments

@SomeoneSerge
Copy link
Contributor

Hi! Observations first. I noticed that openai/triton vendors a copy of ptxas and distributes it in the published wheels. In NixOS/nixpkgs#222273 and NixOS/nixpkgs#227420 this mean making the triton package as "unfree", which prevents users from building it unless they explicitly opt-in (also, this prevents our CI from building the binary cache for the package). I also see that the pypi page declares the project as MIT, despite the wheels redistributing ptxas.

@Jokeren
Copy link
Contributor

Jokeren commented May 4, 2023

Q2. You can use the TRITON_PTXAS_PATH env variable.

@ptillet
Copy link
Collaborator

ptillet commented May 4, 2023

Q1. Yeah, I'd accept a PR that does this, as long as it's not the default behavior :)

ZzEeKkAa pushed a commit to ZzEeKkAa/triton that referenced this issue Aug 5, 2024
Use PyTorch version as a part of the composite key for each E2E
dependency that requires PyTorch.
Fixes triton-lang#1618.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants