Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action to automatically push to pypi on Release x.y.z commit #681

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

rom1504
Copy link
Contributor

@rom1504 rom1504 commented Dec 13, 2022

Publishing whisper on pypi will help use it much more conveniently. It's very easy to do so, and require minimal effort from your part.

The only steps to do would be to :

  1. merge this PR
  2. create a token there https://pypi.org/manage/account/token/
  3. put it in there https://github.com/openai/whisper/settings/secrets/actions/new , name it PYPI_PASSWORD

Then the release will be triggered automatically when you name a commit Release x.y.z
I advise to change the version in setup.py in that commit

@nick-konovalchuk
Copy link
Contributor

Check #627

@rom1504
Copy link
Contributor Author

rom1504 commented Dec 20, 2022

I merged in my fork and released https://pypi.org/project/whisper-openai/

if you wish to run this yourself, I'll gladly remove the pypi package and let you do it

in the meantime, pip install whisper-openai works

@ghost
Copy link

ghost commented Dec 31, 2022

When will this PR be merged?

@nick-konovalchuk
Copy link
Contributor

nick-konovalchuk commented Jan 13, 2023

When will this PR be merged?

Probably never, since in #627 one of the authors stated that releasing a pipy package is not planned at all

@rom1504
Copy link
Contributor Author

rom1504 commented Jan 13, 2023

Well as far as I'm concerned this problem is already solved. The package is on pypi and usable. It takes about 2min every 6month to deploy a new version.
I guess I'll do it if the upstream maintainer does not want to.

@rom1504 rom1504 closed this Jan 13, 2023
@jongwook jongwook reopened this Jan 17, 2023
@jongwook jongwook merged commit b9f9b43 into openai:main Jan 17, 2023
@jongwook
Copy link
Collaborator

Hi, thanks for the PR. I wasn't ready to go fully enterprise open-source with semantic versioning and everything, but date-based versioning seems manageable. The package is now available as openai-whisper on PyPI. I'll make the release commits after any nontrivial updates. Hope this helps!

@rom1504
Copy link
Contributor Author

rom1504 commented Jan 18, 2023 via email

zackees pushed a commit to zackees/whisper that referenced this pull request May 5, 2023
…it (openai#681)

* Add github action to automatically push to pypi on Release x.y.z commit

* some housekeeping for pypi upload

* add version.py

Co-authored-by: Jong Wook Kim <jongwook@nyu.edu>
ilanit1997 pushed a commit to ilanit1997/whisper that referenced this pull request May 16, 2023
…it (openai#681)

* Add github action to automatically push to pypi on Release x.y.z commit

* some housekeeping for pypi upload

* add version.py

Co-authored-by: Jong Wook Kim <jongwook@nyu.edu>
abyesilyurt pushed a commit to abyesilyurt/whisper that referenced this pull request Nov 13, 2023
…it (openai#681)

* Add github action to automatically push to pypi on Release x.y.z commit

* some housekeeping for pypi upload

* add version.py

Co-authored-by: Jong Wook Kim <jongwook@nyu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants