Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused "read" action from Store plugin #361

Merged
merged 1 commit into from
May 9, 2014

Conversation

nickstenning
Copy link
Member

The "read" action is unused by the current implementation of the Store plugin.
All retrieval of annotations is done through the .query() method, which maps
to the "search" action.

The "read" action is unused by the current implementation of the Store
plugin. All retrieval of annotations is done through the .query()
method, which maps to the "search" action.
@tilgovi
Copy link
Member

tilgovi commented Apr 12, 2014

Should we make it usable rather than remove it? I could see a use where specific ids are known and want to be loaded. I guess most query handlers would have a way to query by id but why force that path?

@nickstenning
Copy link
Member Author

I'd much rather just stick with .query() as the one way of getting annotations out of a store. The arguments to .query() (and, by extension, .load()) are a black box, so you can implement whatever you like in there.

As things are now, .load({id: 123}) with the default Store will Just Work. It's not exactly verbose :).

@tilgovi
Copy link
Member

tilgovi commented Apr 13, 2014

Yeah cool.
On Apr 12, 2014 5:29 PM, "Nick Stenning" notifications@github.com wrote:

I'd much rather just stick with .query() as the one way of getting
annotations out of a store. The arguments to .query() (and, by extension,
.load()) are a black box, so you can implement whatever you like in there.

As things are now, .load({id: 123}) will Just Work. It's not exactly
verbose :).


Reply to this email directly or view it on GitHubhttps://github.com//pull/361#issuecomment-40296180
.

tilgovi added a commit that referenced this pull request May 9, 2014
Remove unused "read" action from Store plugin
@tilgovi tilgovi merged commit 975fb02 into master May 9, 2014
@tilgovi tilgovi deleted the remove-read-from-store branch May 9, 2014 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants