Fix for duplicated editor control buttons #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilgovi
added a commit
that referenced
this pull request
Jun 17, 2015
Fix for duplicated editor control buttons
|
Thanks! Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on integrating meltdown with annotator and found a weird error where the control buttons would get duplicated on reloads after the meltdown editor was initialized. Screenshot of the duplicated controls attached since it's a bit difficult to describe (and the error was actually compounded and became much worse on subsequent loads).
I've made an adjustment so that annotator controls are only added after the first ul, not every ul element inside the annotation editor widget, and it resolves the problem.