Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tick format #1441

Closed
mountrcg opened this issue Dec 16, 2022 · 2 comments
Closed

Tick format #1441

mountrcg opened this issue Dec 16, 2022 · 2 comments

Comments

@mountrcg
Copy link
Contributor

Is there a reason why Tick being positive is a String as in +5, wheres if it is negative it' a number. Makes it troublesome in some clients.
@scottleibrand
Copy link
Contributor

We didn’t coerce it beyond just adding the + for display, so that’s what it defaults to. A PR to make them both strings would be fine, or you could switch those clients to use delta (always a number) for things they don’t want as strings.

@mountrcg
Copy link
Contributor Author

Thanks a lot Scott, that helps. So I will adjust on my side, no PR necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mountrcg @scottleibrand