Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider carbs from more than DIA hours ago in advanced-meal-assist #82

Closed
scottleibrand opened this issue Mar 6, 2016 · 3 comments
Closed

Consider carbs from more than DIA hours ago in advanced-meal-assist #82

scottleibrand opened this issue Mar 6, 2016 · 3 comments

Comments

@scottleibrand
Copy link
Contributor

Currently oref0-meal.js ignores any carbs more than DIA hours ago when calculating COB. For really large meals that take more than DIA hours to absorb, would be good to consider older carbs as well.
@scottleibrand
Copy link
Contributor Author

Before we do this, we also need to figure out how to deal with carbs that were absorbed but didn't cause BG to rise, for example due to a long walk home from dinner, or due to overestimating meal carbs.

@scottleibrand
Copy link
Contributor Author

Fixed in 137304b

@scottleibrand
Copy link
Contributor Author

I don't think we actually need to explicitly deal with overestimated carbs: if BG isn't rising from them, they won't have any effect on the predictions or recommendations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scottleibrand