Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1: update as many references as possible from vault to openbao #2

Merged
merged 11 commits into from
May 22, 2024

Conversation

jessebot
Copy link
Contributor

@jessebot jessebot commented May 21, 2024

Description

  • Fixes Update references from vault to openbao #1 by updating as many references to vault to openbao (or bao where appropriate)
  • removes jira related workflow left over from hashicorp's internal process
  • updates github.com/openbao/openbao/api module to point at latest commit in upstream openbao/openbao repo and ran go mod tidy
  • attempts to have tests run on pull request and not just push or manual workflow runs

Signed-off-by: jessebot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Signed-off-by: JesseBot <jessebot@linux.com>
points at v1.9.3-0.20240330013750-f20d4684d48c instead and then I ran go mod tidy

Signed-off-by: jessebot <jessebot@linux.com>
…drop support for testing unsupported versions of k8s

Signed-off-by: jessebot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
@jessebot jessebot marked this pull request as ready for review May 21, 2024 10:29
Signed-off-by: JesseBot <jessebot@linux.com>
@jessebot jessebot requested a review from naphelps May 21, 2024 13:05
Signed-off-by: jessebot <jessebot@linux.com>
Signed-off-by: jessebot <jessebot@linux.com>
… has not changed upstream

Signed-off-by: jessebot <jessebot@linux.com>
…ao-helm

Signed-off-by: jessebot <jessebot@linux.com>
@jessebot
Copy link
Contributor Author

jessebot commented May 22, 2024

This is now ready for review and merge. The only portion that can't fully test is the integration with the helm chart, as it requires an image be pushed up, and we don't have that yet, but the rest of everything related to linting and testing passed, and you can verify it here: https://github.com/jessebot/openbao-csi-provider/actions/runs/9188218819

@naphelps naphelps merged commit f32bd38 into openbao:main May 22, 2024
6 of 9 checks passed
@zjs
Copy link

zjs commented May 22, 2024

It seems like there are still some references in .release/ci.hcl, .release/release-metadata.hcl, and .github/workflows/tests.yaml. Is that intentional?

@jessebot
Copy link
Contributor Author

jessebot commented May 22, 2024

@zjs no it was not intentional, sorry about that! Please feel free to submit a second PR tackling that as part of resolving #3. Or, if you're too busy, I can also do it 🙏 Update: I had the repo already up and needed to clean up this old branch, so I have added the following draft PR: #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update references from vault to openbao
3 participants