Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork projects for first class Kubernetes support #40

Open
JanMa opened this issue Jan 9, 2024 · 14 comments
Open

Fork projects for first class Kubernetes support #40

JanMa opened this issue Jan 9, 2024 · 14 comments
Labels
enhancement New feature or request

Comments

@JanMa
Copy link
Member

JanMa commented Jan 9, 2024

Vault has first class Kubernetes support by offering a HELM chart, CSI driver and Agent injector. If OpenBao should also make Vault on Kubernetes a first class citizen, then we need to fork the relevant upstream projects. Otherwise we should remove the relevant Kubernetes docs from the OpenBao documentation.

@naphelps naphelps added the enhancement New feature or request label Jan 10, 2024
@djds
Copy link

djds commented Jan 18, 2024

Also, https://github.com/hashicorp/vault-secrets-operator is pretty cool but switched to BSL with hashicorp/vault-secrets-operator@cc1b024

cipherboy pushed a commit to cipherboy/openbao that referenced this issue Jan 21, 2024
* workflows: add bulk dep update job

* remove dependabot
cipherboy pushed a commit to cipherboy/openbao that referenced this issue Jan 21, 2024
Co-authored-by: hc-github-team-secure-vault-ecosystem <hc-github-team-secure-vault-ecosystem@users.noreply.github.com>
@yuval9313
Copy link

I rely on vault secrets operator and would like to see an open source version of it as well, I wish that first-clas k8s support would be maintained

Thank you for all the job you have made this far :)

@jessebot
Copy link

Also, https://github.com/hashicorp/vault-secrets-operator is pretty cool but switched to BSL with hashicorp/vault-secrets-operator@cc1b024

I think this means that the fork could start from here though right? (the commit before the license change):
https://github.com/hashicorp/vault-secrets-operator/tree/06bc1738beb805455cc875f1b41e96ec35ecb514

If I'm not wrong, this is the helm chart: https://github.com/hashicorp/vault-helm
The helm chart has a "Mozilla Public License 2.0" license. Can that be forked safely?

@JanMa
Copy link
Member Author

JanMa commented Mar 22, 2024

Hey @jessebot you're right regarding both points. The fork can start at the last commit that is still MPL licensed, and those projects are in general save to fork.

@jessebot
Copy link

@JanMa awesome, thanks for the quick response! If those repos are forked under the openbao org, I would be happy to pinged for help on the k8s side of things. I maintain a lot of helm charts, so if there's something specific to those, I can help :)

@JanMa
Copy link
Member Author

JanMa commented Mar 22, 2024

That's great, thanks a lot @jessebot. I'll let you know once we have those repos available in our org

@AdrianAbraham
Copy link

Please also include support for https://github.com/hashicorp/vault-k8s . Our projects rely on the older "Agent Injector" instead of the newer "Vault Secrets Operator" or "Vault CSI Provider."

@JanMa
Copy link
Member Author

JanMa commented Apr 4, 2024

@jessebot @AdrianAbraham we have now forked the relevant repos into our org:

@zjs
Copy link

zjs commented Apr 25, 2024

Vault CSI Provider

Are there plans to fork this as well? Seems like it switched to BSL here: hashicorp/vault-csi-provider@9910eb3

@jessebot
Copy link

jessebot commented May 16, 2024

Vault CSI Provider

Are there plans to fork this as well? Seems like it switched to BSL here: hashicorp/vault-csi-provider@9910eb3

I'm also interested in this as it's one of the official hashicorp images that is currently set as a default for images in the forked helm chart. See openbao/openbao-helm#3 for more info.

@JanMa
Copy link
Member Author

JanMa commented May 19, 2024

@jessebot @zjs is a fork of the CSI driver really necessary in your opinion? If possible if would like us to only support one way to sync secrets from Vault/OpenBao to K8S long term and I think the Vault/Openbao Secrets Operator is the much more "Kubernetes native" way to do that because in the end it just creates Kubernetes Secrets.

@jessebot
Copy link

@JanMa I think we should still support it as it may be a security requirement for some, unless I'm misunderstanding the CSI driver architecture, as some may not want to use k8s secrets due to the data just being base64 encoded rather than encrypted (though k3s offers encryption at rest now, and that's kinda cool). I know a user can also use RBAC to restrict others from creating/viewing secrets too though, so maybe for right now we could avoid forking the csi driver? Snyk is pretty famous in the security space and they use secrets 🤔 We would need to remove the injector stuff from the helm chart though too, and that feels like we're losing that feature.

I do have a question on the secrets operator though, as I haven't used that one. I've only ever used the external-secrets operator. What's the difference?

I'm interested in others' opinions on both points as well since for right now I mostly use secrets with all the caveats I mentioned before via ESO 🤷

@JanMa
Copy link
Member Author

JanMa commented May 19, 2024

I do have a question on the secrets operator though, as I haven't used that one. I've only ever used the external-secrets operator. What's the difference?

I think conceptually they are very similar. From what I understand, the main difference is that ESO only supports the KV secret engine whereas the Vault/OpenBao Operator supports all secret engines out of the box.

@jessebot
Copy link

jessebot commented May 21, 2024

@zjs, update: openbao/openbao-csi-provider is now available, however it won't be ready until at least the following are resolved:

Also, this Issue can probably be closed as all the correct repos are now forked, yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants