Changelog process - enforce GH workflow #31
Labels
docs
Improvements or additions to documentation
Comments
cipherboy
pushed a commit
to cipherboy/openbao
that referenced
this issue
Jan 21, 2024
Co-authored-by: hashicorp-tsccr[bot] <hashicorp-tsccr[bot]@users.noreply.github.com>
cipherboy
pushed a commit
to cipherboy/openbao
that referenced
this issue
Jan 21, 2024
|
Thanks, @cipherboy . I need to look at this. |
|
#70 should remove the unnecessary changelog entries. |
2 tasks
cipherboy
added a commit
to cipherboy/openbao
that referenced
this issue
Mar 2, 2024
This retains the original HashiCorp upstream build & test pipelines, cleaning them up for OpenBao and removing HashiCorp internal tooling references that aren't necessary for us. The CI pipeline currently fails with test errors and commenting will need to be tested on the main repository with an appropriately scoped token. However, builds pass and produce usable, unsigned artifacts. This can form the basis of a proper (signed) release pipeline eventually, taking actions from the build stage of the tagged release commit and signing and verifying them. In order to fix CI, some changes to the Go modules were done, removing redundant tooling packages and re-adding the kubernetes integration tests. This also fixes CI to correctly run api & sdk tests, fixing openbao#61 again. Removed, unnecessary actions: - actionlint was used to allow-list actions upstream, - add-hashicorp-contributed-label was used to add a label to internal PRs for visibility, - backport was the tool to automatically backport PRs, - milestone-checker was used to ensure PRs had appropriate milestones prior to merge, - oss was used to classify issues against the specified label category - remove-labels was used to clean up issues & PRs - security-scan requires internal tooling not made public - test-ci-bootstrap & test-ci-cleanup are both part of the complex Enos integration tests, which were removed in 85455fb due to resource requirements. Resolves: openbao#31 Resolves: openbao#152 Related: openbao#153 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
added a commit
to cipherboy/openbao
that referenced
this issue
Mar 3, 2024
This retains the original HashiCorp upstream build & test pipelines, cleaning them up for OpenBao and removing HashiCorp internal tooling references that aren't necessary for us. The CI pipeline currently fails with test errors and commenting will need to be tested on the main repository with an appropriately scoped token. However, builds pass and produce usable, unsigned artifacts. This can form the basis of a proper (signed) release pipeline eventually, taking actions from the build stage of the tagged release commit and signing and verifying them. In order to fix CI, some changes to the Go modules were done, removing redundant tooling packages and re-adding the kubernetes integration tests. This also fixes CI to correctly run api & sdk tests, fixing openbao#61 again. Removed, unnecessary actions: - actionlint was used to allow-list actions upstream, - add-hashicorp-contributed-label was used to add a label to internal PRs for visibility, - backport was the tool to automatically backport PRs, - milestone-checker was used to ensure PRs had appropriate milestones prior to merge, - oss was used to classify issues against the specified label category - remove-labels was used to clean up issues & PRs - security-scan requires internal tooling not made public - test-ci-bootstrap & test-ci-cleanup are both part of the complex Enos integration tests, which were removed in 85455fb due to resource requirements. Resolves: openbao#31 Resolves: openbao#152 Related: openbao#153 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
added a commit
to cipherboy/openbao
that referenced
this issue
Mar 3, 2024
This retains the original HashiCorp upstream build & test pipelines, cleaning them up for OpenBao and removing HashiCorp internal tooling references that aren't necessary for us. The CI pipeline currently fails with test errors and commenting will need to be tested on the main repository with an appropriately scoped token. However, builds pass and produce usable, unsigned artifacts. This can form the basis of a proper (signed) release pipeline eventually, taking actions from the build stage of the tagged release commit and signing and verifying them. In order to fix CI, some changes to the Go modules were done, removing redundant tooling packages and re-adding the kubernetes integration tests. This also fixes CI to correctly run api & sdk tests, fixing openbao#61 again. Removed, unnecessary actions: - actionlint was used to allow-list actions upstream, - add-hashicorp-contributed-label was used to add a label to internal PRs for visibility, - backport was the tool to automatically backport PRs, - milestone-checker was used to ensure PRs had appropriate milestones prior to merge, - oss was used to classify issues against the specified label category - remove-labels was used to clean up issues & PRs - security-scan requires internal tooling not made public - test-ci-bootstrap & test-ci-cleanup are both part of the complex Enos integration tests, which were removed in 85455fb due to resource requirements. Resolves: openbao#31 Resolves: openbao#42 Resolves: openbao#152 Related: openbao#153 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
pushed a commit
to cipherboy/openbao
that referenced
this issue
Mar 5, 2024
This retains the original HashiCorp upstream build & test pipelines, cleaning them up for OpenBao and removing HashiCorp internal tooling references that aren't necessary for us. The CI pipeline currently fails with test errors and commenting will need to be tested on the main repository with an appropriately scoped token. However, builds pass and produce usable, unsigned artifacts. This can form the basis of a proper (signed) release pipeline eventually, taking actions from the build stage of the tagged release commit and signing and verifying them. In order to fix CI, some changes to the Go modules were done, removing redundant tooling packages and re-adding the kubernetes integration tests. This also fixes CI to correctly run api & sdk tests, fixing openbao#61 again. Removed, unnecessary actions: - actionlint was used to allow-list actions upstream, - add-hashicorp-contributed-label was used to add a label to internal PRs for visibility, - backport was the tool to automatically backport PRs, - milestone-checker was used to ensure PRs had appropriate milestones prior to merge, - oss was used to classify issues against the specified label category - remove-labels was used to clean up issues & PRs - security-scan requires internal tooling not made public - test-ci-bootstrap & test-ci-cleanup are both part of the complex Enos integration tests, which were removed in 85455fb due to resource requirements. Resolves: openbao#31 Resolves: openbao#42 Resolves: openbao#152 Related: openbao#153 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
naphelps
pushed a commit
that referenced
this issue
Mar 5, 2024
This retains the original HashiCorp upstream build & test pipelines, cleaning them up for OpenBao and removing HashiCorp internal tooling references that aren't necessary for us. The CI pipeline currently fails with test errors and commenting will need to be tested on the main repository with an appropriately scoped token. However, builds pass and produce usable, unsigned artifacts. This can form the basis of a proper (signed) release pipeline eventually, taking actions from the build stage of the tagged release commit and signing and verifying them. In order to fix CI, some changes to the Go modules were done, removing redundant tooling packages and re-adding the kubernetes integration tests. This also fixes CI to correctly run api & sdk tests, fixing #61 again. Removed, unnecessary actions: - actionlint was used to allow-list actions upstream, - add-hashicorp-contributed-label was used to add a label to internal PRs for visibility, - backport was the tool to automatically backport PRs, - milestone-checker was used to ensure PRs had appropriate milestones prior to merge, - oss was used to classify issues against the specified label category - remove-labels was used to clean up issues & PRs - security-scan requires internal tooling not made public - test-ci-bootstrap & test-ci-cleanup are both part of the complex Enos integration tests, which were removed in 85455fb due to resource requirements. Resolves: #31 Resolves: #42 Resolves: #152 Related: #153 Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the changelog process uses
go-changelogfor generation.It seems like some changelog entries were removed (which IMO, is good as we don't want to maintain it retroactively for prior upstream versions) -- but we likely want to remove the rest which snuck in.
In particular, changelog entries are numbered off of PR numbers (and the README is generally helpful), so we'll have a ways to go before they'll conflict :-)
There should be a label (
pr/no-changelog) which avoids the checker in the GH action; it might be nice to make this a required workflow.Are there any thoughts on the existing process (doc'd in that README)? Should we choose something else or is this generally amenable to everyone?
The text was updated successfully, but these errors were encountered: