Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork: Rename Environment Variables #138

Merged
merged 3 commits into from
Feb 27, 2024
Merged

fork: Rename Environment Variables #138

merged 3 commits into from
Feb 27, 2024

Conversation

Mab879
Copy link
Contributor

@Mab879 Mab879 commented Feb 12, 2024

This PR will allow users to configure OpenBAO with both VAULT_ and BAO_ prefixes for environment variables.

Resolves #66

Target Release

GA

@Mab879 Mab879 force-pushed the fix_66 branch 3 times, most recently from 9a78e73 to dcce1f8 Compare February 15, 2024 02:07
@Mab879 Mab879 marked this pull request as ready for review February 23, 2024 15:30
Copy link
Member

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Mab879!

ReadBaoVariable will check given a "BAO_" variable check if its defined
as a BAO_ or VAULT_ so that both can be used.

Signed-off-by: Matthew Burket <m@tthewburket.com>
Signed-off-by: Matthew Burket <m@tthewburket.com>
Signed-off-by: Matthew Burket <m@tthewburket.com>
@naphelps naphelps merged commit 80e0533 into openbao:main Feb 27, 2024
3 of 9 checks passed
@Mab879 Mab879 deleted the fix_66 branch February 27, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fork: Rename Environment Variables
3 participants