Swap hashicorp/consul-template to openbao/openbao-template #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
merge-consul-template
branch
from
7fac304
to
9f31aa7
Compare
cipherboy
changed the title
cipherboy
force-pushed
the
merge-consul-template
branch
from
9f31aa7
to
f59f407
Compare
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
merge-consul-template
branch
from
f59f407
to
1e4b2ae
Compare
naphelps
approved these changes
Feb 28, 2024
naphelps
pushed a commit
to naphelps/openbao
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be rebased once #138, #157, openbao/openbao-template#2, & openbao/openbao-template#3 merge.This swaps
hashicorp/consul-templatewith the newly trimmed down and rebrandedopenbao-template, dropping support from that code base for Consul & Nomad -- this allows us to fully remove the Nomad API/SDK from our final binary here (saving us two MB) -- though Consul remains for service discovery here.If you run:
with openbao-template pull request 3 above checked out a directory above this project's
go.mod(i.e., sibling directories of this checkout), the tests should pass now on this branch but fail onmain.