Remove eventing & experimental subsystems #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eventing subsystem was the only pre-release experiment present in upstream's 1.14.x branch; this wasn't stabilized and more widely used until later release (1.15.x and the upcoming 1.16.x); and so makes little sense to keep in its partial form. Additionally, no existing plugins within this distribution currently emit such events. By removing eventing, we can also remove the experiments subsystem; this was only used for enabling the eventing subsystem in this release. See also: https://developer.hashicorp.com/vault/docs/concepts/events Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>
cipherboy
force-pushed
the
remove-beta-eventbus
branch
from
63e33f6
to
60ce888
Compare
naphelps
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eventing subsystem was the only pre-release experiment present in
upstream's 1.14.x branch; this wasn't stabilized and more widely used
until later release (1.15.x and the upcoming 1.16.x); and so makes
little sense to keep in its partial form. Additionally, no existing
plugins within this distribution currently emit such events.
By removing eventing, we can also remove the experiments subsystem; this
was only used for enabling the eventing subsystem in this release.
See also: https://developer.hashicorp.com/vault/docs/concepts/events
Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>Based on #194, will be rebased once that merges.