Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

splitLineCSV throws error #22

Closed
andrewjaykeller opened this issue Aug 10, 2016 · 6 comments
Closed

splitLineCSV throws error #22

andrewjaykeller opened this issue Aug 10, 2016 · 6 comments
Labels
bug

Comments

@andrewjaykeller
Copy link

andrewjaykeller commented Aug 10, 2016 •
edited
Loading

Trying to run master and getting this error...

screen shot 2016-08-10 at 1 36 25 pm
@andrewjaykeller andrewjaykeller mentioned this issue Aug 10, 2016
Closed
@andrewjaykeller
Copy link
Author

This is because of a bug with processing 3.1.2, do not update!

@andrewjaykeller
Copy link
Author

From the processing guys, we should never have used splitLineCSV() and functions like these are subject to change in minor updates to processing!! See this issue here! processing/processing#4611

andrewjaykeller pushed a commit to andrewjaykeller/OpenBCI_GUI that referenced this issue Aug 17, 2016
Fix: splitLineCSV bug closes OpenBCI#22
53776fd
@andrewjaykeller andrewjaykeller mentioned this issue Aug 17, 2016
Closed
@cfausn
Copy link
Contributor

cfausn commented Sep 2, 2016

I've found that passing the buffer to splitLineCSV() fixes this bug with newer processing. Simply change it to splitLineCSV(line, reader)

@andrewjaykeller
Copy link
Author

andrewjaykeller commented Sep 2, 2016 •
edited
Loading

I disagree. splitLineCSV is a protected function and should not be used in the application.

Check out processing/processing#4611

I got yelled at for that line hahaha

@cfausn
Copy link
Contributor

cfausn commented Sep 2, 2016 •
edited
Loading

haha interesting. For the newest version of processing though it doesn't let you compile without passing in the reader, dunno why. As of version 3.2.1 at least.

@andrewjaykeller
Copy link
Author

They changed the interface for that function from one arg to two args... see #25 PR for a fix andrewjaykeller@53776fd#diff-5fbebc9acb054941aa8e1303d08be960R241

@andrewjaykeller andrewjaykeller changed the title splitLineCSV throws error splitLineCSV throws error Nov 2, 2016
daniellasry pushed a commit to daniellasry/OpenBCI_GUI that referenced this issue Jan 30, 2019
@retiutut
Merge pull request OpenBCI#22 from daniellasry/retiutut-development
11f48e4 
Fixed synthetic data accelerometer graph being tied to the framerate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: splitLineCSV bug closes #22 andrewjaykeller/OpenBCI_GUI
2 participants
@andrewjaykeller @cfausn