Merge 0.8.19 hotfix2 into 0.8.21 #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taways * OBPIH-4684 Allow admin/manager/assistant to delete pending putaways * OBPIH-4684 Check for minimum required role which is assistant
#3621) * OBPIH-5078 Fix request feature for location without manage_inventory and with submit_request, but not having type Ward * Add comment to the supported activity util function Co-authored-by: Artur Walkowiak <awalkowiak@soldevelo.com>
(request from ward = location without manage inventory, but with submit request activity code)
…3627) (request from ward = location without manage inventory, but with submit request activity code)
- same binLocation comparison resulting in false because of different HashCodes
* OBPIH-4932 Unable to delete request as superuser * OBPIH-4932 Fixes after review * OBPIH-5136 enable deletion of a stock request Co-authored-by: kchelstowski <squall.ask@gmail.com>
- when deleting request from ward redirect to dashboard - set minimum required role for request deletion to Assistant
* OBPIH-5138 HOTFIX: QOH on blur updating quantity requested over and over * OBPIH-5138 Fixes after review (create separate function for calculating qty requested)
…3644) * OBPIH-5138 HOTFIX: QOH on blur updating quantity requested over and over * OBPIH-5138 Fixes after review (create separate function for calculating qty requested) * OBPIH-5138 Broken request from ward save when using stocklist * OBPIH-5138 Assign proper value to subtract from when request is: manual, stocklist push, stocklist pull
* OBPIH-5138 Fix for QOH being an empty string
kchelstowski
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work, that was done for the Dominica implementation as a 0.8.19-hotfix2. We should move it to the master (release), as to not run into these changes being lost when updating Dominica to the newest version in the future.