Skip to content

Commit

Permalink
disable the network change notifier because it seems to be broken,
Browse files Browse the repository at this point in the history
so this way the browser will report an online status all the time
and web applications checking the status will work again until the
actual issue with the notifier is fixed
  • Loading branch information
rnagy committed Jul 25, 2019
1 parent eee962c commit 4a42641
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
3 changes: 2 additions & 1 deletion www/chromium/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# $OpenBSD: Makefile,v 1.447 2019/07/16 16:59:25 robert Exp $
# $OpenBSD: Makefile,v 1.448 2019/07/25 12:07:26 robert Exp $

.include <bsd.port.arch.mk>

Expand All @@ -12,6 +12,7 @@ DPB_PROPERTIES+= lonesome
COMMENT= Chromium browser

V= 75.0.3770.142
REVISION= 0

DISTNAME= chromium-${V}

Expand Down
14 changes: 10 additions & 4 deletions www/chromium/patches/patch-net_base_network_change_notifier_cc
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
$OpenBSD: patch-net_base_network_change_notifier_cc,v 1.30 2019/05/11 20:37:14 robert Exp $
$OpenBSD: patch-net_base_network_change_notifier_cc,v 1.31 2019/07/25 12:07:26 robert Exp $

XXX disable network change notifier and always report ONLINE

Index: net/base/network_change_notifier.cc
--- net/base/network_change_notifier.cc.orig
+++ net/base/network_change_notifier.cc
Expand All @@ -11,16 +14,19 @@ Index: net/base/network_change_notifier.cc
#include "net/base/network_change_notifier_posix.h"
#elif defined(OS_FUCHSIA)
#include "net/base/network_change_notifier_fuchsia.h"
@@ -206,7 +206,7 @@ NetworkChangeNotifier* NetworkChangeNotifier::Create()
@@ -206,8 +206,9 @@ NetworkChangeNotifier* NetworkChangeNotifier::Create()
// Android builds MUST use their own class factory.
CHECK(false);
return NULL;
-#elif defined(OS_CHROMEOS)
- return new NetworkChangeNotifierPosix(CONNECTION_NONE, SUBTYPE_NONE);
+#elif defined(OS_CHROMEOS) || defined(OS_BSD)
return new NetworkChangeNotifierPosix(CONNECTION_NONE, SUBTYPE_NONE);
+ return NULL;
+// return new NetworkChangeNotifierPosix(CONNECTION_NONE, SUBTYPE_NONE);
#elif defined(OS_LINUX)
return new NetworkChangeNotifierLinux(std::unordered_set<std::string>());
@@ -215,7 +215,6 @@ NetworkChangeNotifier* NetworkChangeNotifier::Create()
#elif defined(OS_MACOSX)
@@ -215,7 +216,6 @@ NetworkChangeNotifier* NetworkChangeNotifier::Create()
#elif defined(OS_FUCHSIA)
return new NetworkChangeNotifierFuchsia(0 /* required_features */);
#else
Expand Down

0 comments on commit 4a42641

Please sign in to comment.