Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News Read more... button #2359

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

stefopl
Copy link
Contributor

@stefopl stefopl commented Jul 5, 2022

Request from a member of the OC Team:
Possibility to display a shorter news on the home page with a button to the News page where the full version is. I have enabled page break in tinyMCE. Now you just need to use the button to insert this tag/comment in the selected place and the text will be displayed on the main page only up to this point.
image
image

Additionally, I replaced the plugin code in tinyMCE with code_editor. Now editing the code is easier to read because there is syntax highlighting.
image
image

@@ -2416,6 +2416,7 @@
'news_removePicSuccess' => 'Obrazek usunięty',
'news_actionInProgress' => 'Trwa usuwanie',
'news_removePic' => 'Usuń obrazek',
'news_read_more' => 'Czytaj więcej...',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid this won't go. The opencaching-pl code uses crowdin.com for some time to entering language localizations, so modifications in language localization files directly in github PR are not allowed.
You can sign up/login in crowdin, ask for access to opencaching-pl project, enter translations (in case of new tr keys, first wait until this PR is merged) and wait for your changes to be accepted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I reverted the changes pl.php and sent a request for access to the project on cordvin.com

@kojoty
Copy link
Member

kojoty commented Jun 19, 2023

Cześć @stefopl
Chciałbym trochę posprzątać tutaj - czy ten PR jest jeszcze aktualny? Jeśli tak dalbys radę rozwiązać konflikty i spróbujemy to margować...

@stefopl
Copy link
Contributor Author

stefopl commented Jun 19, 2023

Hej @kojoty PR nadal aktualny, konflikty rozwiązane. Jeżeli jest tu za duży bałagan w commiatch i tych merge master to mogę zrobić nowego PR albo w tym zrobić squash i force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants