Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP-CS-Fixer configuration #2410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrmajor
Copy link
Contributor

@jrmajor jrmajor commented Jul 31, 2024

Disabling all rules except for the passing ones leaves us with green CI even if we check all files. Contributors will no longer be forced to reformat every changed file, making diffs more readable. The disabled rules can be fixed and enabled one by one in follow-up PRs.

@jrmajor jrmajor marked this pull request as ready for review August 3, 2024 22:11
@jrmajor
Copy link
Contributor Author

jrmajor commented Aug 3, 2024

Couldn't get the workflow to run on this PR. Maybe it will only run on PRs after it's merged? Seems like it ran in my fork: https://github.com/jrmajor/opencaching-pl/commits/php-cs-fixer-config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant