Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc2repo: refactor configuration file syntax #46

Open
pdowler opened this issue Dec 8, 2021 · 0 comments
Open

sc2repo: refactor configuration file syntax #46

pdowler opened this issue Dec 8, 2021 · 0 comments

Comments

@pdowler
Copy link
Member

pdowler commented Dec 8, 2021

The sc2repo.properties config file has a really old format that is very inconsistent with the (improved) practices we adopted in storage inventory (specifically thinking of baldur and raven where one creates an “entry” and then a set of properties for it on separate lines.

I don’t think it would be much work to implement a new config style like
ca.nrc.cadc.caom2.repo.entry = FOO
FOO.basePublisherID = ??
FOO.readOnlyGroup = ??
FOO.readWriteGroup = ??
FOO.operatorGroup = ??
FOO.staffGroup = ??
FOO.proposalGroup = true

Technically, only basePublisherID and readWriteGroup are required for a functional repo service.

In the sc2repo impl, there is only one database and we currently have only one maintained SQLGenerator impl, so the other config items are not really configurable separately (the pool and database are in the context.xml and confdigurable props go into catalina.properties).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant