Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache $(this) and use jQuery dom obj for dropdown #4288

Merged
merged 2 commits into from Apr 25, 2016
Merged

cache $(this) and use jQuery dom obj for dropdown #4288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc0f65e
cache $(this) and use jQuey dom el for dropdown
pine3ree Apr 25, 2016
886d272
Update common.js
pine3ree Apr 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 21 additions & 18 deletions upload/admin/view/javascript/common.js
View file
Open in desktop
Expand Up @@ -251,27 +251,30 @@ $(document).ready(function() {
(function($) {
$.fn.autocomplete = function(option) {
return this.each(function() {
var $this = $(this);
var $dropdown = $('<ul class="dropdown-menu" />');

this.timer = null;
this.items = new Array();
this.items = [];

$.extend(this, option);

$(this).attr('autocomplete', 'off');
$this.attr('autocomplete', 'off');

// Focus
$(this).on('focus', function() {
$this.on('focus', function() {
this.request();
});

// Blur
$(this).on('blur', function() {
$this.on('blur', function() {
setTimeout(function(object) {
object.hide();
}, 200, this);
});

// Keydown
$(this).on('keydown', function(event) {
$this.on('keydown', function(event) {
switch(event.keyCode) {
case 27: // escape
this.hide();
Expand All @@ -295,19 +298,19 @@ $(document).ready(function() {

// Show
this.show = function() {
var pos = $(this).position();
var pos = $this.position();

$(this).siblings('ul.dropdown-menu').css({
top: pos.top + $(this).outerHeight(),
$dropdown.css({
top: pos.top + $this.outerHeight(),
left: pos.left
});

$(this).siblings('ul.dropdown-menu').show();
$dropdown.show();
}

// Hide
this.hide = function() {
$(this).siblings('ul.dropdown-menu').hide();
$dropdown.hide();
}

// Request
Expand Down Expand Up @@ -335,14 +338,15 @@ $(document).ready(function() {
}

// Get all the ones with a categories
var category = new Array();
var category = [];

for (i = 0; i < json.length; i++) {
if (json[i]['category']) {
if (!category[json[i]['category']]) {
category[json[i]['category']] = new Array();
category[json[i]['category']]['name'] = json[i]['category'];
category[json[i]['category']]['item'] = new Array();
category[json[i]['category']] = {
name: json[i]['category'],
item: []
};
}

category[json[i]['category']]['item'].push(json[i]);
Expand All @@ -364,12 +368,11 @@ $(document).ready(function() {
this.hide();
}

$(this).siblings('ul.dropdown-menu').html(html);
$dropdown.html(html);
}

$(this).after('<ul class="dropdown-menu"></ul>');
$(this).siblings('ul.dropdown-menu').delegate('a', 'click', $.proxy(this.click, this));

$dropdown.on('click', '> li > a', $.proxy(this.click, this));
$this.after($dropdown);
});
}
})(window.jQuery);