Refactored and improved the loop controller #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianKniephoff
force-pushed
the
i74/remove-plugin-mechanism
branch
from
e682df0
to
63a31b3
Compare
JulianKniephoff
force-pushed
the
i74/remove-plugin-mechanism
branch
from
63a31b3
to
26bb348
Compare
This is only the markup and style side of things. This new menu entry won't do anything, yet.
JulianKniephoff
force-pushed
the
i74/remove-plugin-mechanism
branch
from
26bb348
to
d00cff3
Compare
|
Could you create the loop view as a pinned row that does not move if I scroll the tracks? |
|
Phew, I mean probably I could, but that would mean mucking around with the DOM and/or CSS a lot, I think. I could make some experiments, but I would prefer you make another issue for that, since that is definitely outside the scope of this PR, imo. 🙂 |
|
Okay. I created two new issues for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite what I said in #74, this turned out not to be necessary to fix the missing translations ... I really just overlooked them ... 😅
But it also doesn't hurt, especially in view of #24.
As an "apology" I threw in a fix for #42, which was easy having looked at the Loop Controller a bit closer now. 😉