-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize redux: recordingSlice #257
Modernize redux: recordingSlice #257
Conversation
Turns out even more of the parameters for the addNotification function in the notificationThunks are perfectly optional.
Fixes a "can't access lexical declaration 'X' before initialization" error, by resolving a kind of circular dependency.
Fixes a "can't access lexical declaration 'X' before initialization" error, by resolving a kind of circular dependency.
Switching to redux toolkit for getting recordings for the recording table (which is translated as "Location" in the ui).
This pull request has conflicts ☹ |
Adds typing on what we expect the backend to return for recordings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locations/recordings table is working. (See #242 (review) for more info on these approvals)
This pull request has conflicts ☹ |
This pull request has conflicts ☹ |
This pull request has conflicts ☹ |
…oolkit-recordings
Helps with #213.
Switching to redux toolkit for getting recordings for the recording table (which is translated as "Location" in the ui).