Automatically publish conatiner image #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a `Dockerfile` and a GitHub Actions workflow to automatically build and publish container images for every branch and pull request. If the source is a pull request, the workflow will also add a comment to explain how this can be used to easily test this pull reqzest: > Use `docker` or `podman` to test this pull request locally. > > Local test with mock data > ``` > podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/lkiesow/opencast-admin-interface:pr-5 > ``` > > Proxy data from develop.opencast.org > ``` > podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://develop.opencast.org ghcr.io/lkiesow/opencast-admin-interface:pr-5 > ``` > > It may take a few seconds for the interface to spin up. > It will then be available at https://127.0.0.1:3000.
Please don't make that assumption. I want to add production-ready images for all static front-end repositories (similar to opencast/opencast-editor#684). |
|
As we discussed at the technical meeting:
|
This was referenced May 28, 2024
ziegenberg
approved these changes
May 29, 2024
|
Looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
Dockerfileand a GitHub Actions workflow to automatically build and publish container images for every branch and pull request.If the source is a pull request, the workflow will also add a comment to explain how this can be used to easily test this pull request:
Right now, this will run on all pull requests instead of just running on pull requests for members of the team Developer like we have for the Opencast Editor. We have to authorize unknown contributors anyway before GitHub runs workflows at all and we also only use the package repository for testing.