Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wordings in finish menu #1311

Merged
merged 3 commits into from
May 2, 2024

Conversation

dennis531
Copy link
Collaborator

Change the the wording of the "Start processing" button to "Save and publish changes" to better differentiate the buttons. Additionally, this should highlight that videos can be published with this button.

I haven't changed the existing translations, as I don't know what to do with them.

Related #1131

@dennis531 dennis531 added the type:usability Usability improvements label Apr 15, 2024
Copy link

This pull request is deployed at test.editor.opencast.org/1311/2024-04-15_12-00-05/ .
It might take a few minutes for it to become available.

@ziegenberg
Copy link
Member

I don't know if that change is desirable. The workflow may or may not publish the video. How about "Save and start processing"?

@dennis531
Copy link
Collaborator Author

I don't know if that change is desirable. The workflow may or may not publish the video. How about "Save and start processing"?

I had the same thoughts when I changed the texts. I agree that we should keep "processing" and append "save" to the text.

Copy link

This pull request is deployed at test.editor.opencast.org/1311/2024-04-19_14-20-52/ .
It might take a few minutes for it to become available.

@dennis531
Copy link
Collaborator Author

I have repaced the text by "Save and process changes" to make it clearer that this means the saving and processing of changes. It is also more consistent with the other labels.

Copy link
Member

@ziegenberg ziegenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@KatrinIhler
Copy link
Member

Change looks fine, but i wonder how we can trigger a re-translation of this. Maybe we should rename the translation key (append new or something)?

@ziegenberg
Copy link
Member

Shouldn't Crowdin handle those cases? The English string has changed, so it comes up again for all translators.

@KatrinIhler
Copy link
Member

Shouldn't Crowdin handle those cases? The English string has changed, so it comes up again for all translators.

I don't know if that's how it works? If it is, that'd be great.

@ziegenberg
Copy link
Member

Maybe @gregorydlogan or @lkiesow, who know how Crowdin works, want to chime in. We should document "How to handle translation" afterwards.

@KatrinIhler
Copy link
Member

From the dev meeting: We assume that changing the English translation string will prompt re-translation into the other languages in Crowdin. :)

@gregorydlogan
Copy link
Member

Will clarify in the docs as a separate PR, but yes that's my understanding. Changing the translated (non-en_US) strings is frowned upon because they will blindly be overwritten by the Crowdin bot and this can also cause merge conflicts going upwards towards Develop.

Copy link

github-actions bot commented May 2, 2024

This pull request is deployed at test.editor.opencast.org/1311/2024-05-02_06-55-25/ .
It might take a few minutes for it to become available.

@dennis531
Copy link
Collaborator Author

@gregorydlogan Thanks for the clarification. I reverted the german translations.

@KatrinIhler KatrinIhler merged commit 24c5548 into opencast:main May 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants