Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context menu for cutting actions #1318

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

dennis531
Copy link
Collaborator

Displays a context menu over the cutting timeline when the user clicks on it with the right (secondary) mouse button.

Closes #943

@dennis531 dennis531 added the type:usability Usability improvements label Apr 25, 2024
@dennis531 dennis531 self-assigned this Apr 25, 2024
Copy link

This pull request is deployed at test.editor.opencast.org/1318/2024-04-25_14-00-33/ .
It might take a few minutes for it to become available.

Copy link
Member

@lkiesow lkiesow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dennis531 dennis531 removed their assignment Apr 26, 2024
@kai-wng-uos
Copy link
Collaborator

I really like this change!

@ziegenberg
Copy link
Member

Shouldn't we only change the en-us.json locale file because Crowdin does the translation?

@dennis531
Copy link
Collaborator Author

I reverted the tranlation files as suggested in #1311 (comment).

Copy link

github-actions bot commented May 2, 2024

This pull request is deployed at test.editor.opencast.org/1318/2024-05-02_06-53-06/ .
It might take a few minutes for it to become available.

@lkiesow
Copy link
Member

lkiesow commented May 6, 2024

Shouldn't really matter since they would just be overwritten by the Crowdin changes. But it's reverted now, so nevermind.
Merging.

@lkiesow lkiesow merged commit ffbcbe0 into opencast:main May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:usability Usability improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add right click menu for cutting
4 participants