-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbnail Editor #760
Thumbnail Editor #760
Conversation
This pull request is deployed at test.editor.opencast.org/760/2022-08-17_07-25-21/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is deployed at test.editor.opencast.org/760/2022-08-18_10-29-35/ . |
This pull request is deployed at test.editor.opencast.org/760/2022-08-19_06-23-40/ . |
I agree with @geichelberger
The box could have more width or at least some padding left and right. The text is right at the border and looks a bit squeezed. First one: Maybe you could make the buttons "Generate" and "Use for other thumbnails" the same size? (See picture, I adjusted the size for these two buttons above). When the buttons have the same size, they maybe look more uniform/consistent? Second thing: When I generate a thumbnail, the thumbnail and the buttons are very far apart. If you use a zooming-software, you (maybe) don't see that they belong together. (Something I learned about accessibility :D ) And the third thing: The box is right at the bottom of the page. I think some |
This pull request is deployed at test.editor.opencast.org/760/2022-08-19_08-09-00/ . |
Thanks for your feedback. That'll teach me to only test things in Chrome and think "Should I test other browers? Naah, it'll be fine". |
True. I know what you mean. Most of the time I only test in Firefox (as for my review). In Chrome it doesn't take the whole width, when you generated a thumbnail. This time I tested in Firefox and Chrome. The buttons look way better now and the view in Chrome fits very well There are more things I noticed: (edited)
Btw: I test with Fedora 35 and Firefox 103.0 and Chrome 104.0. This is how it looks with Firefox: |
Oh no, you were faster than me. Let me check and correct my review. |
This pull request is deployed at test.editor.opencast.org/760/2022-08-19_09-05-04/ . |
Could you be more specific? The page looks pretty dark in dark mode to me. |
I updated my last review. It looks way better now in Firefox. |
I agree with your assessment that the thumbnail preview ought to be bigger and the buttons can be smaller, so I tried to implement that. Although I tried to refrain from using |
This pull request is deployed at test.editor.opencast.org/760/2022-09-05_13-51-46/ . |
I personally don't mind the length of "Use for other thumbnails". I always like to try and make the UI more dynamic before resorting to shorten the text, as it ends up helping out with translations (especially the germans somehow always end up with words that are way too long). I also find "Use for other thumbnails" easier to understand than shorter alternatives. But I can also see the case for a shorter version. Ultimately I don't care too much about the name of the buttons, maybe everyone could vote for their favourite version on crowdin? |
This pull request is deployed at test.editor.opencast.org/760/2022-09-05_14-14-44/ . |
…umbnails display size
This pull request is deployed at test.editor.opencast.org/760/2022-09-06_07-03-20/ . |
This pull request is deployed at test.editor.opencast.org/760/2022-09-06_07-53-21/ . |
Another thing I found. The buttons increase their size when hovering over them. That's OK. They also increase their size when clicking. That's also OK. But they stay in the increased size, after clicking and when no longer hovering over them. I have to click somewhere else for them to be restored to their original size. |
and also create a button component
This pull request is deployed at test.editor.opencast.org/760/2022-09-06_13-24-32/ . |
This pull request is deployed at test.editor.opencast.org/760/2022-09-06_13-32-55/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This pull request is deployed at test.editor.opencast.org/760/2022-09-06_14-46-20/ . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Great work.
I am missing german translations, but this should not stop this PR from being merged.
The approach of creating the thumbnail client side has a considerable disadvantage. The thumbnail quality depends on the video editor preview, which usually has a lower quality/resolution. I think that's not a show-stopper for this PR, but there is room for improvement. |
I created a new issue for this comment: #814 |
Adds a new view which allows users to create thumbnails for their events.
Allows users to:
Has a "simple" and a "professional" mode.
Requires Opencast backend PR to function: opencast/opencast#4086