Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer batch transformation functions to ocf_datapipes #111

Closed
dfulu opened this issue Dec 21, 2023 · 3 comments · Fixed by openclimatefix/ocf_datapipes#287 or #170
Closed

Transfer batch transformation functions to ocf_datapipes #111

dfulu opened this issue Dec 21, 2023 · 3 comments · Fixed by openclimatefix/ocf_datapipes#287 or #170
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dfulu
Copy link
Member

dfulu commented Dec 21, 2023

Transfer the copy_batch_to_device and batch_to_tensor functions from pvnet/data/utils.py to ocf_datapipes. These functions are specific to the NumPyBatch object in datapipes, so I think it makes sense for them to go there

@dfulu dfulu added enhancement New feature or request good first issue Good for newcomers labels Dec 21, 2023
@aryanbhosale
Copy link
Member

Transfer the copy_batch_to_device and batch_to_tensor functions from pvnet/data/utils.py to ocf_datapipes. These functions are specific to the NumPyBatch object in datapipes, so I think it makes sense for them to go there
Hi @dfulu , I'm unable to find ocf_datapipes. Could you please help me out here?

@markus-kreft
Copy link
Contributor

Hi all,

I have just opened openclimatefix/ocf_datapipes#287. Once discussions on type hints there are done and it is merged, I have a PR ready to make use of the functions.

@aryanbhosale: I started looking into this yesterday and only now saw that you are also working on it. But I would be very happy about feedback on my PR if you are also interested in this issue.

@dfulu
Copy link
Member Author

dfulu commented Mar 11, 2024

Hi both, thanks very much for jumping on this!

@aryanbhosale I'm sure you've found ocf_datapipes by now, but here it is anyway: https://github.com/openclimatefix/ocf_datapipes

It looks like the two of you have this handled. Let me know if you have any more questions and please feel free to tag me directly in any pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants