Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cobra.sampling.sampling #1060

Merged
merged 8 commits into from
Mar 23, 2021
Merged

refactor: cobra.sampling.sampling #1060

merged 8 commits into from
Mar 23, 2021

Conversation

synchon
Copy link
Member

@synchon synchon commented Mar 22, 2021 •
edited
Loading

  • description of feature/fix
  • tests added/passed

This PR refactors cobra.sampling.sampling module to improve Python 3.6+ compatibility.

@synchon synchon self-assigned this Mar 22, 2021
@synchon synchon added enhancement WIP work in progress ready Finished PR that requires review and merge. and removed WIP work in progress labels Mar 22, 2021
@synchon
Copy link
Member Author

synchon commented Mar 23, 2021

Rebased on latest devel.

Midnighter
Midnighter approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the one sentence in the docstring can be improved but otherwise it looks good.

src/cobra/sampling/sampling.py Show resolved Hide resolved
@synchon
Copy link
Member Author

synchon commented Mar 23, 2021

The tests fail due to connection failure when performing test_web tests. Shouldn't be a problem for merging.

@synchon synchon merged commit 3745ac6 into devel Mar 23, 2021
@synchon synchon deleted the refactor/sampling-sampling branch March 23, 2021 10:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Midnighter Midnighter Midnighter approved these changes

@cdiener cdiener Awaiting requested review from cdiener

Assignees

@synchon synchon

Labels
enhancement ready Finished PR that requires review and merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@synchon @Midnighter