Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code fixes #21

Closed
VatsalBhuva11 opened this issue Dec 17, 2023 · 4 comments
Closed

Code fixes #21

VatsalBhuva11 opened this issue Dec 17, 2023 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers Points: 5

Comments

@VatsalBhuva11
Copy link
Collaborator

Small fixes;

  • Only the room's creator should be able to update the room name and description, and remove other users from the room
  • Hence, create a separate controller to allow a logged in user to disconnect themselves (route should be /api/v1/room/user/disconnect
  • Also change the /api/v1/room/user/delete route to /api/v1/room/user/remove for better semantics (explains the action of one person, here the room creator, removing someone and not deleting them).
    It's not competitive, as it's quite easy
@criticic
Copy link
Contributor

claim

@VatsalBhuva11 VatsalBhuva11 added bug Something isn't working good first issue Good for newcomers Points: 5 labels Dec 17, 2023
@VatsalBhuva11
Copy link
Collaborator Author

@criticic assigned

@VatsalBhuva11
Copy link
Collaborator Author

@criticic quick work! well done.

@VatsalBhuva11
Copy link
Collaborator Author

i will add your points manually. sorry, forgot to assign you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers Points: 5
Projects
None yet
Development

No branches or pull requests

2 participants