recent changes in atom_types.cc broke bioscience module in https://github.com/opencog/agi-bio

[mjsduncan]

cross referenced with issue opencog/agi-bio#73

[ 50%] Building CXX object bioscience/types/CMakeFiles/bioscience-types.dir/BioScienceTypes.cc.o
<command-line>:0:10: warning: missing terminating " character
In file included from /home/cog/opencog/agi-bio/bioscience/types/BioScienceTypes.cc:28:0:
/usr/local/include/opencog/atoms/base/atom_types.cc: In function ‘void init()’:
/usr/local/include/opencog/atoms/base/atom_types.cc:43:40: error: ‘class opencog::ClassServer’ has no member named ‘beginTypeDecls’
  bool is_init = opencog::classserver().beginTypeDecls(xstr(INITNAME));
                                        ^
In file included from /usr/local/include/opencog/atoms/base/atom_types.cc:46:0,
                 from /home/cog/opencog/agi-bio/bioscience/types/BioScienceTypes.cc:28:
/home/cog/opencog/agi-bio/build/bioscience/types/atom_types.inheritance:5:45: error: ‘class opencog::ClassServer’ has no member named ‘declType’
 opencog::GENE_NODE = opencog::classserver().declType(opencog::CONCEPT_NODE, "GeneNode");
                                             ^

/home/cog/opencog/agi-bio/build/bioscience/types/atom_types.inheritance:6:48: error: ‘class opencog::ClassServer’ has no member named ‘declType’
 opencog::PROTEIN_NODE = opencog::classserver().declType(opencog::CONCEPT_NODE, "ProteinNode");
                                                ^
In file included from /home/cog/opencog/agi-bio/bioscience/types/BioScienceTypes.cc:28:0:
/usr/local/include/opencog/atoms/base/atom_types.cc:50:25: error: ‘class opencog::ClassServer’ has no member named ‘endTypeDecls’
  opencog::classserver().endTypeDecls();
                         ^
bioscience/types/CMakeFiles/bioscience-types.dir/build.make:78: recipe for target 'bioscience/types/CMakeFiles/bioscience-types.dir/BioScienceTypes.cc.o' failed

[linas]

The changes were made in #1698 by @konstantin-t who didn't know agi-bio existed, and I just forgot.

The fix is to do what was done in opencog/opencog#3132 -- look at the diffs there, perform the same changes in agi-bio.

Sorry!

[linas]

Should be fixed by opencog/agi-bio#74. Sorry about that, the developer who did the work could have been a bit more backwards-compat in the design