Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlCard slot id #103

Closed
LimeHat opened this issue Nov 30, 2023 · 1 comment · Fixed by #113
Closed

ControlCard slot id #103

LimeHat opened this issue Nov 30, 2023 · 1 comment · Fixed by #113
Assignees

Comments

@LimeHat
Copy link

LimeHat commented Nov 30, 2023

bootz.proto defines control card slot id as a numeric (int32) value

bootz/proto/bootz.proto

Lines 75 to 80 in b8d7fb3

// Details of the control card, including serial-number and the location
// of the card on the chassis.
message ControlCard {
string part_number = 1;
string serial_number = 2;
int32 slot = 3;
, however OpenConfig uses type string for component ID and location leafs:
https://github.com/openconfig/public/blob/cd1cfcd263d033ee5f9b10cddde6f823f6cb30e2/release/models/platform/openconfig-platform.yang#L391, and not all vendors use numeric values for control cards.

Can this be changed to string?

cc @xw-g

@gmacf
Copy link
Contributor

gmacf commented Dec 1, 2023

This sounds sensible. Changing proto field types is risky but I can make a new field called "slot_id" or similar and eventually deprecate the old one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants