Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factory_reset service and concurrent calls to Start RPC #91

Open
hellt opened this issue Aug 4, 2022 · 0 comments
Open

factory_reset service and concurrent calls to Start RPC #91

hellt opened this issue Aug 4, 2022 · 0 comments

Comments

@hellt
Copy link
Contributor

hellt commented Aug 4, 2022

Hi all,
I would like to discuss what is the right way for a target to handle concurrent Start RPC calls in the scope of a Factory Reset service?

Consider the following call flow

T0 (client) StartReq → (target)

T1 (target) StartResp:Success → (client)

-- target prepares the reset--

T5 (client) StartReq → (target)

T6 (target) ??? → (client)

At time T5 a client sends another StartRequest to the target; the target is already in the process of handling a previous StartRequest, but not yet in a shutdown state, so it receives the request.
Should it respond with another StartResponse:Success and meaning that the reset is going to happen, or should it send back an gRPC error with a description that explains that another reset request has already been requested?

/cc @samribeiro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant