Updating blkio default value in man page #1142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rajasec <rajasec79@gmail.com>
cyphar
reviewed
Oct 23, 2016
| @@ -33,7 +33,7 @@ other options are ignored. | |||
|
|
|||
| # OPTIONS | |||
| --resources value, -r value path to the file containing the resources to update or '-' to read from the standard input | |||
| --blkio-weight value Specifies per cgroup weight, range is from 10 to 1000 (default: 0) | |||
| --blkio-weight value Specifies per cgroup weight, range is from 10 to 1000 (0 to use system default) | |||
There was a problem hiding this comment.
This should match the output of runc --help (so you have to change that as well). Also I'd make the default text match for all of the options (the line below has a different format).
|
@rajasec Can you update and rebase? |
|
needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0 is invalid value for blkio value and will be rejected by kernel. Internally in runc implementation also we did not explicitly set 0 value. So it will take from parent cgroup.
updated the man page accordingly.
Signed-off-by: rajasec rajasec79@gmail.com