validator: unbreak sysctl net.* validation #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When changing this validation, the code actually allowing the validation to pass was removed. This meant that any net.* sysctl would always fail to validate. Fixes: bc84f83 ("fix moby/moby#27484") Reported-by: Justin Cormack <justin.cormack@docker.com> Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
I've also added a test -- it turns out we weren't testing that |
Previously we only tested failures, which causes us to miss issues where setting sysctls would *always* fail. Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
Ah, sorry about it. I was too careless. LGTM |
|
Don't sweat it. 😸 /cc @opencontainers/runc-maintainers |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changing this validation, the code actually allowing the validation
to pass was removed. This meant that any net.* sysctl would always fail
to validate.
Fixes: bc84f83 ("fix moby/moby#27484")
Reported-by: Justin Cormack justin.cormack@docker.com
Signed-off-by: Aleksa Sarai asarai@suse.de
Fixes #1138
/cc @justincormack Does this fix the issue you mentioned?