[1.0]: ci: add go 1.17, drop go 1.15 #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kolyshkin
force-pushed
the
1.0-go-1.17
branch
from
b84f51c
to
857abc5
Compare
|
Weird; the CI failure should be fixed by commit fdee865. Ahh, somehow I managed to use very old release-1.0 branch. Should be fixed now. |
Closed
AkihiroSuda
reviewed
Nov 30, 2021
| @@ -18,7 +18,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| # Docker/Moby still builds runc with Go 1.13, so we should still support Go 1.13. | |||
There was a problem hiding this comment.
I know Moby moved on, but I'm not sure about everybody else.
This is a maintenance branch, perhaps it makes sense to keep 1.13 compatibility since the cost is zero (unless we'll want to backport something massive) and it might save someone a big headache.
There was a problem hiding this comment.
Yeah, the comment is no longer "correct", but it I guess it's fine to keep the 1.13 version in the test-matrix for now (it's just a single word).
|
I have removed go 1.15 tests as required for release-1.0 branch. TODO: add go 1.17 tests as required once this is merged. |
AkihiroSuda
previously approved these changes
Nov 30, 2021
thaJeztah
reviewed
Nov 30, 2021
kolyshkin
force-pushed
the
1.0-go-1.17
branch
from
857abc5
to
83ec813
Compare
Add Go 1.17, grop 1.15 from CI; since 1.17 release 1.15 is unsupported. Keep 1.13 in 1.0 branch, since an older version of Docker/Moby might use it. Keep 1.16 in Dockerfile, since this is a stable branch and we'd rather not swap horses in the middle of the stream. This corresponds to commit a587180 in main branch. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
1.0-go-1.17
branch
from
83ec813
to
e73ff66
Compare
AkihiroSuda
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #3021 but for release-1.0.
Add Go 1.17, grop 1.15 from CI; since 1.17 release 1.15 is unsupported.
Keep 1.13 in 1.0 branch, since an older version of Docker/Moby might use it.
Keep 1.16 in Dockerfile, since this is a stable branch.