Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.1] cgroups: systemd: skip adding device paths that don't exist #3504

Merged
merged 1 commit into from
Jun 8, 2022
Merged

[1.1] cgroups: systemd: skip adding device paths that don't exist #3504

merged 1 commit into from
Jun 8, 2022

Conversation

cyphar
Copy link
Member

@cyphar cyphar commented Jun 7, 2022

Backport of #3498.

Signed-off-by: Aleksa Sarai cyphar@cyphar.com

@cyphar cyphar added the backport/1.1-pr A backport to 1.1.x release. label Jun 7, 2022
@cyphar cyphar added this to the 1.1.3 milestone Jun 7, 2022
@cyphar cyphar marked this pull request as ready for review June 7, 2022 23:47
kolyshkin
kolyshkin previously approved these changes Jun 7, 2022
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given that CI is green

systemd emits very loud warnings when the path specified doesn't exist
(which can be the case for some of our default rules). We don't need the
ruleset we give systemd to be completely accurate (we discard some kinds
of wildcard rules anyway) so we can safely skip adding these.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
@kolyshkin
Copy link
Contributor

@thaJeztah @AkihiroSuda PTAL

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyphar cyphar mentioned this pull request Jun 7, 2022
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants