Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix absolute path getting for runc binary #47

Merged
merged 1 commit into from
Jun 27, 2015

Conversation

LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Jun 26, 2015

ping @estesp

Signed-off-by: Alexander Morozov <lk4d4@docker.com>
@estesp
Copy link
Contributor

estesp commented Jun 26, 2015

Yes, this is more correct, and fixes issues/PRs noted in #35 and #36

@mrunalp
Copy link
Contributor

mrunalp commented Jun 26, 2015

Yes, I think this approach is better. Testing.

@mrunalp
Copy link
Contributor

mrunalp commented Jun 26, 2015

All 3 cases work:

  1. Relative ./runc
  2. Absolute /usr/bin/runc
  3. From PATH runc

LGTM

@hitsumabushi
Copy link

👍
This pr is better than #36.

@crosbymichael
Copy link
Member

LGTM

crosbymichael added a commit that referenced this pull request Jun 27, 2015
Fix absolute path getting for runc binary
@crosbymichael crosbymichael merged commit b6c196f into opencontainers:master Jun 27, 2015
stefanberger pushed a commit to stefanberger/runc that referenced this pull request Sep 8, 2017
config.md: minor clean up of process specification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants