Set Delegate to true for cgroups transient units #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@mrunalp Do you know which version of systemd added support for |
runcom
pushed a commit
to projectatomic/docker
that referenced
this pull request
Mar 16, 2016
Upstream reference: opencontainers/runc#648 Signed-off-by: Mrunal Patel <mrunalp@gmail.com> Signed-off-by: Antonio Murdaca <runcom@redhat.com>
|
@cyphar i think Delegate=is not supported for systemd < 218. Im not sure if this will result in an error for those systems. LGTM if this works with systemd < 218 😛 |
runcom
pushed a commit
to projectatomic/docker
that referenced
this pull request
Mar 16, 2016
Upstream reference: opencontainers/runc#648 Signed-off-by: Mrunal Patel <mrunalp@gmail.com> Signed-off-by: Antonio Murdaca <runcom@redhat.com>
|
I think we should be fine merging this. Fedora 23 has 222. RHEL 7 has 219. Ubuntu 15.10 has 225 (The last LTS 14.04 did not have it and next 16.04 should have a newer version). |
This is required because we manage some of the cgroups ourselves. This recommendation came from talking with systemd devs about some of the issues that we see when using the systemd cgroups driver. Signed-off-by: Mrunal Patel <mrunalp@gmail.com>
mrunalp
force-pushed
the
cgroups_delegate
branch
from
41eb174
to
93d1a1a
Compare
|
And AFAIK openSUSE Tumblweed and Leap 42.2 will all have systemd >= 218. Thanks for checking. LGTM. |
mrunalp
pushed a commit
that referenced
this pull request
Mar 16, 2016
Set Delegate to true for cgroups transient units
runcom
pushed a commit
to runcom/docker
that referenced
this pull request
Jun 8, 2016
Upstream reference: opencontainers/runc#648 Signed-off-by: Mrunal Patel <mrunalp@gmail.com> Signed-off-by: Antonio Murdaca <runcom@redhat.com>
crawford
pushed a commit
to crawford/docker
that referenced
this pull request
Jun 14, 2016
Upstream reference: opencontainers/runc#648 Signed-off-by: Mrunal Patel <mrunalp@gmail.com> Signed-off-by: Antonio Murdaca <runcom@redhat.com>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Allow negative value for some resource fields
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
This partially revert opencontainers#648 , after a second thought, I think we should use specs value the same as kernel API input, see: opencontainers/runtime-spec#692 (comment) For memory and hugetlb limits *.limit_in_bytes, cgroup APIs take the values as string, but the parsed values are unsigned long, see: https://github.com/torvalds/linux/blob/v4.10/mm/page_counter.c#L175-L193 For `cpu.cfs_quota_us` and `cpu.rt_runtime_us`, cgroup APIs take the input value as signed long long, while `cpu.cfs_period_us` and `cpu.rt_periof_us` take the input value as unsigned long long. Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required because we manage some of the cgroups ourselves.
This recommendation came from talking with systemd devs about
some of the issues that we see when using the systemd cgroups driver.
Signed-off-by: Mrunal Patel mrunalp@gmail.com