Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.0.0 #893

Merged
merged 3 commits into from Jul 19, 2017
Merged

Release v1.0.0 #893

merged 3 commits into from Jul 19, 2017

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Jul 12, 2017 •
edited

@wking
Copy link
Contributor

wking commented Jul 12, 2017 via email

wking and others added 3 commits July 12, 2017 19:28
@wking @vbatts
ChangeLog: Document changes since v1.0.0-rc6
eac58a4 
Through 96de01b (Merge pull request #897 from crosbymichael/pids,
2017-07-12).

Signed-off-by: W. Trevor King <wking@tremily.us>
@vbatts
version: release v1.0.0
02137cd 
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@vbatts
version: bump master back to -dev
84ba019 
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
wking
wking reviewed Jul 12, 2017
View reviewed changes
specs-go/version.go
@@ -11,7 +11,7 @@ const (
VersionPatch = 0

// VersionDev indicates development branch. Releases will be empty string.
VersionDev = "-rc6-dev"
VersionDev = "-dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up until now, -dev has meant “working towards”, so 1.0.0-rc6-dev was followed by 1.0.0-rc6. I'm not sure how we want to handle the post-1.0 world where it's not clear what release we're working on (2.0.0-rc1? 1.1.0-rc1? 1.0.1-rc1?) I'd guess master will most likely target 1.1.0-rc1, so maybe you want to setup 1.1.0-rc1-dev in the tip commit of this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up until now, -dev has meant “working towards”, so 1.0.0-rc6-dev was followed by 1.0.0-rc6.

Oops, that's not right, since this PR is based on a post-rc6 master using 1.0.0-rc6-dev. I think I was confused by pre-release markers sorting earlier in SemVer. So this commit is fine (since we don't care about SemVer sorting between releases), and sorry for the noise.

@tianon
Copy link
Member

tianon commented Jul 13, 2017 •
edited by caniszczyk

LGTM (redux)

Approved with PullApprove

@vbatts
Copy link
Member Author

vbatts commented Jul 19, 2017

This needs another LGTM by tomorrow. 😍

@vbatts
Copy link
Member Author

vbatts commented Jul 19, 2017

@opencontainers/runtime-spec-maintainers ping

@mrunalp
Copy link
Contributor

mrunalp commented Jul 19, 2017 •
edited by vbatts

LGTM

@vbatts
Copy link
Member Author

vbatts commented Jul 19, 2017

weird. Not sure why pullapprove is not jiving with that LGTM

@caniszczyk
Copy link
Contributor

caniszczyk commented Jul 19, 2017 •
edited

LGTM weird, I'll kick PA again

Approved with PullApprove

@vbatts vbatts merged commit 337efca into master Jul 19, 2017
@vbatts vbatts deleted the bump-version branch July 19, 2017 20:01
@vbatts vbatts mentioned this pull request Sep 8, 2017
Merged
@opencontainers opencontainers locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wking wking wking left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vbatts @wking @tianon @mrunalp @caniszczyk