Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.0 #893

Merged
merged 3 commits into from
Jul 19, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,24 @@
OpenContainers Specifications

Changes with v1.0.0:

Breaking changes:

* config: Shift disableOOMKiller from linux.resources to
linux.resources.memory (#896)

Decreased restrictions:

* runtime: Make the state JSON's pid optional on non-Linux platforms
(#897)

Minor fixes and documentation:

* schema/defs-linux: Require Syscall.action (#885)
* specs-go/config: Fix 'omiempty' -> 'omitempty' typo for
LinuxSeccompArg.ValueTwo (#884)
* ROAMAP: remove the pre-v1.0.0 roadmap (#890)

Changes with v1.0.0-rc6:

Breaking changes:
Expand Down
2 changes: 1 addition & 1 deletion specs-go/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const (
VersionPatch = 0

// VersionDev indicates development branch. Releases will be empty string.
VersionDev = "-rc6-dev"
VersionDev = "-dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up until now, -dev has meant “working towards”, so 1.0.0-rc6-dev was followed by 1.0.0-rc6. I'm not sure how we want to handle the post-1.0 world where it's not clear what release we're working on (2.0.0-rc1? 1.1.0-rc1? 1.0.1-rc1?) I'd guess master will most likely target 1.1.0-rc1, so maybe you want to setup 1.1.0-rc1-dev in the tip commit of this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up until now, -dev has meant “working towards”, so 1.0.0-rc6-dev was followed by 1.0.0-rc6.

Oops, that's not right, since this PR is based on a post-rc6 master using 1.0.0-rc6-dev. I think I was confused by pre-release markers sorting earlier in SemVer. So this commit is fine (since we don't care about SemVer sorting between releases), and sorry for the noise.

)

// Version is the specification version that the package types support.
Expand Down