Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: modify the err judgment #462

Merged
merged 1 commit into from
Sep 9, 2017
Merged

Conversation

zhouhao3
Copy link

@zhouhao3 zhouhao3 commented Sep 5, 2017

Modify the following error situation:

✗ oci-runtime-tool validate 
0 errors occurred:


Signed-off-by: zhouhao zhouhao@cn.fujitsu.com

@Mashimiao
Copy link

This is really not a good fix...., you'd better fix take advantage of multierror to fix this in CheckAll()

Signed-off-by: zhouhao <zhouhao@cn.fujitsu.com>
@zhouhao3
Copy link
Author

zhouhao3 commented Sep 7, 2017

updated, PTAL.

@Mashimiao
Copy link

Mashimiao commented Sep 7, 2017

LGTM

Approved with PullApprove

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented Sep 9, 2017

LGTM

Approved with PullApprove

@mrunalp mrunalp merged commit d09d81a into opencontainers:master Sep 9, 2017
@zhouhao3 zhouhao3 deleted the checkerr-fix branch September 10, 2017 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants