validation: run CLI with correct argument order #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OCI Runtime Command Line Interface [1][1] specifies the order of the arguments: ``` $ funC [global-options] <COMMAND> [command-specific-options] <command-specific-arguments> ``` runc [2][2] is flexible whether command-specific-options is before or after command-specific-arguments. But crun [3][3] is not, making the tests fail. Since the CLI spec only specifies one order, the validation tests should respect that order. [1]: https://github.com/opencontainers/runtime-tools/blob/master/docs/command-line-interface.md#global-usage [2]: https://github.com/opencontainers/runc [3]: https://github.com/giuseppe/crun Signed-off-by: Alban Crequy <alban@kinvolk.io>
wking
approved these changes
Mar 9, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCI Runtime Command Line Interface 1 specifies the order of the
arguments:
runc 2 is flexible whether command-specific-options is before or
after command-specific-arguments. But crun 3 is not, making the
tests fail. Since the CLI spec only specifies one order, the validation
tests should respect that order.
Signed-off-by: Alban Crequy alban@kinvolk.io
/cc @giuseppe