Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocrvs 2921 Refactor change phone number components #3661

Merged
merged 13 commits into from
Jul 22, 2022
Merged

Conversation

tahmidrahman-dsi
Copy link
Collaborator

@tahmidrahman-dsi tahmidrahman-dsi commented Jul 19, 2022

phone-change-modal

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #3661 (b1f4300) into develop (e4500b0) will increase coverage by 0.01%.
The diff coverage is 88.76%.

@@             Coverage Diff             @@
##           develop    #3661      +/-   ##
===========================================
+ Coverage    79.89%   79.91%   +0.01%     
===========================================
  Files          629      631       +2     
  Lines        28375    28363      -12     
  Branches      9111     9101      -10     
===========================================
- Hits         22670    22665       -5     
+ Misses        5645     5637       -8     
- Partials        60       61       +1     
Impacted Files Coverage Δ
packages/client/src/App.tsx 100.00% <ø> (ø)
packages/client/src/navigation/index.ts 55.55% <ø> (+0.15%) ⬆️
packages/client/src/navigation/routes.ts 100.00% <ø> (ø)
...es/client/src/views/Settings/items/PhoneNumber.tsx 75.00% <50.00%> (+10.00%) ⬆️
...ews/Settings/ChangePhoneModal/ChangeNumberView.tsx 82.35% <82.35%> (ø)
...views/Settings/ChangePhoneModal/VerifyCodeView.tsx 96.96% <96.96%> (ø)
...ews/Settings/ChangePhoneModal/ChangePhoneModal.tsx 100.00% <100.00%> (ø)
packages/client/src/forms/utils.ts 72.57% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a4a24f...b1f4300. Read the comment docs.

{intl.formatMessage(buttonMessages.cancel)}
</TertiaryButton>,

<Mutation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we perhaps properly type this? The types can be found in gateway.ts file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Zangetsu101, I am on it

@Zangetsu101 Zangetsu101 merged commit f2f287d into develop Jul 22, 2022
@Zangetsu101 Zangetsu101 deleted the ocrvs-2921 branch July 25, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants