Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image size conversion #1593

Merged
merged 5 commits into from
Jun 5, 2020
Merged

Fix image size conversion #1593

merged 5 commits into from
Jun 5, 2020

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented May 25, 2020 •
edited
Loading

Motivation and context

Fixes image size conversion in dataset filter.

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max zhiltsov-max changed the title [WIP] Fix image size conversion Fix image size conversion Jun 3, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5419

  • 4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.009%) to 65.653%
Changes Missing Coverage Covered Lines Changed/Added Lines %
datumaro/datumaro/components/dataset_filter.py 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/components/project.py 1 77.49%
Totals Coverage Status
Change from base Build 5409: 0.009%
Covered Lines: 10839
Relevant Lines: 16105
💛 - Coveralls

nmanovic
nmanovic previously approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmanovic
nmanovic approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 1b413c6 into develop Jun 5, 2020
@nmanovic nmanovic deleted the zm/dm-fix-filter-repr branch June 5, 2020 08:03
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
@zhiltsov-max @nmanovic
Fix image size conversion (cvat-ai#1593)
f009b6b 
* Fix image size conversion

* update changelog

Co-authored-by: Nikita Manovich <40690625+nmanovic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmanovic nmanovic nmanovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiltsov-max @coveralls @nmanovic