Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CVAT-UI] Better labels validation and fixed React warning #1727

Merged
merged 4 commits into from
Jun 16, 2020

Conversation

bsekachev
Copy link
Member

Motivation and context

When use raw representation of labels, some errors aren't validated. It confuses our users. What's more there is a warning in React related with unique keys. This PR fixes these issues.

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Resolve #1498

@bsekachev bsekachev added the bug Something isn't working label Jun 16, 2020
@bsekachev bsekachev requested a review from nmanovic as a code owner June 16, 2020 09:21
Copy link
Contributor

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- cvat-ui/src/components/labels-editor/common.ts  6
         

See the complete overview on Codacy

@coveralls
Copy link

coveralls commented Jun 16, 2020

Pull Request Test Coverage Report for Build 5797

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.795%

Totals Coverage Status
Change from base Build 5743: 0.0%
Covered Lines: 10924
Relevant Lines: 16207

💛 - Coveralls

@bsekachev bsekachev merged commit 3adaf7e into develop Jun 16, 2020
@bsekachev bsekachev added this to Done in UI via automation Jun 16, 2020
@bsekachev bsekachev deleted the bs/added_validation branch June 17, 2020 15:42
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
)

* Better validation

* Temporary ID generation for created labels and attributes (fixes React warning)

* Updated version and changelog

* Fixed bug with existing labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
UI
  
Done
Development

Successfully merging this pull request may close these issues.

Add message in UI when raw labels are wrong
4 participants