Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datumaro] Fixes #1953

Merged
merged 6 commits into from
Jul 29, 2020
Merged

[Datumaro] Fixes #1953

merged 6 commits into from
Jul 29, 2020

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

  • Bboxes in COCO format no more converted to polygons on exporting. This allows to better keep original annotations.
  • REST API extractor produces images with absolute paths to its cache.
  • Datumaro format keeps input image paths (including absolute ones).
  • Fixed definition in datumaro format tests.

How has this been tested?

Unit tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max zhiltsov-max added this to In progress in Dataset framework (Datumaro) via automation Jul 28, 2020
@coveralls
Copy link

coveralls commented Jul 28, 2020

Pull Request Test Coverage Report for Build 6631

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 65.015%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 1 77.29%
Totals Coverage Status
Change from base Build 6627: -0.003%
Covered Lines: 11104
Relevant Lines: 16676

💛 - Coveralls

azhavoro
azhavoro previously approved these changes Jul 28, 2020
nmanovic
nmanovic previously approved these changes Jul 29, 2020
Dataset framework (Datumaro) automation moved this from In progress to Reviewer approved Jul 29, 2020
@nmanovic nmanovic dismissed stale reviews from azhavoro and themself via 7f84d43 July 29, 2020 18:54
Dataset framework (Datumaro) automation moved this from Reviewer approved to Review in progress Jul 29, 2020
@nmanovic nmanovic merged commit 0062ecd into develop Jul 29, 2020
Dataset framework (Datumaro) automation moved this from Review in progress to Done Jul 29, 2020
@nmanovic nmanovic deleted the zm/dm-fixes branch July 29, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants