Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old UI #1964

Merged
merged 7 commits into from
Aug 3, 2020
Merged

Remove old UI #1964

merged 7 commits into from
Aug 3, 2020

Conversation

nmanovic
Copy link
Contributor

@nmanovic nmanovic commented Jul 30, 2020

Motivation and context

Remove the deprecated UI source code. We are not going to support both versions.

How has this been tested?

Manual testing only.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@nmanovic nmanovic changed the title [WIP] Removed outdated code [WIP] Remove old UI Jul 30, 2020
@coveralls
Copy link

coveralls commented Jul 30, 2020

Pull Request Test Coverage Report for Build 6731

  • 11 of 16 (68.75%) changed or added relevant lines in 3 files are covered.
  • 105 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 69.093%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cvat/apps/engine/urls.py 7 12 58.33%
Files with Coverage Reduction New Missed Lines %
src/frames.js 3 23.31%
src/session.js 102 54.35%
Totals Coverage Status
Change from base Build 6672: 0.05%
Covered Lines: 11145
Relevant Lines: 15620

💛 - Coveralls

@bsekachev
Copy link
Member

Karma and qunit probably aren't needed anymore in Dockerfile.ci

@nmanovic nmanovic changed the title [WIP] Remove old UI Remove old UI Aug 2, 2020
@nmanovic
Copy link
Contributor Author

nmanovic commented Aug 3, 2020

@azhavoro , could you please look and test?

@nmanovic nmanovic merged commit 634ca17 into develop Aug 3, 2020
@nmanovic nmanovic deleted the nm/remove-old-ui branch August 3, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants